Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keymap's methods now match those of cw-Map #75

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Keymap's methods now match those of cw-Map #75

wants to merge 2 commits into from

Conversation

eshelB
Copy link
Contributor

@eshelB eshelB commented Feb 13, 2023

insert -> save
get -> load
contains -> has

@eshelB eshelB added the match cw-storage-plus Issue aims to cause api to conform to cw-storage-plus' types label Feb 13, 2023
toml01
toml01 reviewed Feb 19, 2023
View reviewed changes
Copy link
Member

@toml01 toml01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.
Can we change the key parameter to key: K (no reference) across the board to match the cw-storage-plus API better?

@eshelB
Copy link
Contributor Author

eshelB commented Feb 20, 2023

@toml01, Of course, this is done in a different PR - #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toml01 toml01 toml01 approved these changes

Assignees
No one assigned
Labels
match cw-storage-plus Issue aims to cause api to conform to cw-storage-plus' types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eshelB @toml01